Drop the builtin category and move the missing variables to appropriate es* categories (#140) #158
+7
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the ESLint version of the configuration file, do we actually want a es2020 section now? |
Yup |
|
I’d prefer not to drop builtin completely. It can be generated from the other categories to keep it in sync if that’s the concern. I think it’s valuable to keep as a collection of all globals. |
|
@Standard8 , is anything holding you back from moving the three |
|
Closing for lack of response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements what was outlined in #140. The only missing items in the es* categories were the
BigIntrelated ones, and theglobalThis.I have put them in the
es2017section as that is the latest one there. I wasn't quite sure if that was right or not.